Skip site navigation (1) Skip section navigation (2)

pgsql: Fix some more bugs in git_changelog.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix some more bugs in git_changelog.
Date: 2010-09-26 04:22:58
Message-ID: E1OzilO-0000ce-BK@gemulon.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Fix some more bugs in git_changelog.

1. Don't forget the last (oldest) commit on the oldest branch.

2. When considering which commit to print next, if two alternatives have
the same "distortion" score (which is actually the normal case, since
generally the "distortion" is 0), then choose the later timestamp to
print first.  I don't know where Robert got the idea to ignore timestamps
and sort by branch age, but it wasn't a good idea: the resulting ordering
of commits was just plain bizarre anywhere that some branches had many
fewer commits than others, which is the typical situation for us.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=30d2e1005838c7ece353ef2ac269cfdc37e937be

Modified Files
--------------
src/tools/git_changelog |   37 +++++++++++++++++++------------------
1 files changed, 19 insertions(+), 18 deletions(-)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-09-26 05:51:32
Subject: pgsql: Still more tweaking of git_changelog.
Previous:From: Tom LaneDate: 2010-09-26 00:52:39
Subject: Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group