pgsql: Minor improvements to git_changelog.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Minor improvements to git_changelog.
Date: 2010-09-26 00:51:04
Message-ID: E1OzfSK-0006GJ-2Z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Minor improvements to git_changelog.

Avoid depending on Date::Calc, which isn't in a basic Perl installation,
when we can equally well use Time::Local which is. Also fix the parsing
of timestamps to take heed of the timezone. (It looks like cvs2git emitted
all commit timestamps with zone GMT, so this refinement might've looked
unnecessary when looking at converted data; but it's needed now.)

Fix parsing of message bodies so that blank lines that may or may not get
emitted by "git log" aren't confused with real data. This avoids strange
formatting of the oldest commit on a branch.

Check child-process exit status, so that we actually notice if "git log"
fails, and so that we don't accumulate zombie children.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=901a5a786fa3cf107ceb11d2622cf8bb99221f3a

Modified Files
--------------
src/tools/git_changelog | 22 ++++++++++++++++------
1 files changed, 16 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-09-26 00:52:39 Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w
Previous Message David Fetter 2010-09-26 00:29:16 Re: pgsql: Fix another join removal bug: the check on PlaceHolderVars was w