From: | "Zeugswetter Andreas ADI SD" <ZeugswetterA(at)spardat(dot)at> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
Cc: | <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [PATCHES] Reviewers Guide to Deferred Transactions/Transaction Guarantee |
Date: | 2007-04-13 13:40:31 |
Message-ID: | E1539E0ED7043848906A8FF995BDA57901E7BF3B@m0143.s-mxs.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
I agree with Tom's reasoning about the suggested simplifications, sorry.
> > 3. Should the WALWriter also do the wal_buffers half-full write at
the
> > start of XLogInsert() ?
>
> That should go away entirely; to me the main point of the
> separate wal-writer process is to take over responsibility
> for not letting too many dirty wal buffers accumulate.
That also sounds a lot simpler, but I think Bruce wanted to be able to
give
some time guarantee to the not waiting for fsync txns.
When a commit only half-filled the page and no more WAL comes in for
a long time, there is only WALWriter to do the IO.
The WALWriter would need to only flush a half-full page after timeout
iff it contains a commit record.
One more question on autocommit:
Do we wait for a flush for an autocommitted DML ?
Seems we generally should not.
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2007-04-13 14:03:44 | Re: conflicting gettimeofday with MinGW |
Previous Message | Simon Riggs | 2007-04-13 13:27:56 | Re: Reviewers Guide to DeferredTransactions/TransactionGuarantee |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-04-13 14:36:44 | Re: [HACKERS] Full page writes improvement, code update |
Previous Message | Simon Riggs | 2007-04-13 13:27:56 | Re: Reviewers Guide to DeferredTransactions/TransactionGuarantee |