Skip site navigation (1) Skip section navigation (2)

Re: Improve shutdown during online backup, take 4

From: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
To: "Tom Lane *EXTERN*" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Magnus Hagander" <magnus(at)hagander(dot)net>,"Alvaro Herrera" <alvherre(at)commandprompt(dot)com>,<pgsql-patches(at)postgresql(dot)org>
Subject: Re: Improve shutdown during online backup, take 4
Date: 2008-04-28 06:57:51
Message-ID: D960CB61B694CF459DCFB4B0128514C2020A7A83@exadv11.host.magwien.gv.at (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> > I've attached a patch that works for me. I hope I got it right.
> 
> Applied with additional cleanup.  You hadn't thought very carefully
> about additional state transitions that would have to be introduced
> into the postmaster state machine to support a new state --- for
> example, as coded a SIGINT delivered to the postmaster after SIGTERM
> would fail to do anything at all, when of course it really ought to
> force us into fast shutdown.  Also, it's not really that hard to
> disallow non-superusers from connecting in PM_WAIT_BACKUP state.

Thank you for helping.
You know, this is my first patch for server code. I know that I
still have a lot to learn until I grok how all that works
together.

Yours,
Laurenz Albe

In response to

pgsql-patches by date

Next:From: Magnus HaganderDate: 2008-04-28 08:13:48
Subject: Re: win32mak_patch
Previous:From: Hiroshi SaitoDate: 2008-04-27 17:00:26
Subject: Re: win32mak_patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group