Skip site navigation (1) Skip section navigation (2)

Re: Improve shutdown during online backup, take 3

From: "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at>
To: "Magnus Hagander *EXTERN*" <magnus(at)hagander(dot)net>
Cc: <simon(at)2ndquadrant(dot)com>,<pgsql-patches(at)postgresql(dot)org>
Subject: Re: Improve shutdown during online backup, take 3
Date: 2008-04-23 08:40:29
Message-ID: D960CB61B694CF459DCFB4B0128514C202043A03@exadv11.host.magwien.gv.at (view raw or flat)
Thread:
Lists: pgsql-patches
Magnus Hagander wrote:
> This doesn't look like our normal coding standards, and should probably
> be changed:
> + 	if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> 
> (there's a number of similar places)

Lacking guidelines, I now tried to copy how stat(2) is used in other parts
of the code.

Yours,
Laurenz Albe


Attachment: backup-shut.patch
Description: application/octet-stream (7.5 KB)
Attachment: backup-shut.doc.patch
Description: application/octet-stream (3.2 KB)

In response to

pgsql-patches by date

Next:From: Magnus HaganderDate: 2008-04-23 08:43:23
Subject: Re: Improve shutdown during online backup, take 4
Previous:From: Simon RiggsDate: 2008-04-23 07:51:32
Subject: Re: Snapshot management, final

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group