Re: Introduction

> -----Original Message-----
> From: John McCawley [mailto:jmccawley(at)worleyco(dot)com]
> Sent: 06 August 2002 17:09
> To: Andy Kelk
> Cc: pgadmin-hackers(at)postgresql(dot)org
> Subject: Re: [pgadmin-hackers] Introduction
>
>
> Andy Kelk wrote:
>
> >I only made modifications to one file: frmSQLInput.frm
> >I have attached this file so you can see the changes. If this is not
> >the way to go about sending modifications, give me a friendly nudge.
> >
> >
>
> Typically you would send a patch file, which is a file that only
> contains the differences between the CVS version and your version.
> Generating these from command line CVS requires you to actually
> remember a command, so I don't do it ;)
>
> On Windows I use Tortoise CVS: http://www.tortoisecvs.org/index.shtml

Yes, patches are definately the nicest way (you can read the changes
easily and merge with the existing source). As with the rest of the
PostgreSQL project, context diffs are preferred. From the command line
in a repository (i.e. *not* a tarball copy) you would do:

cvs diff -c > mypatch.diff

I tend to use Wincvs myself though.

As it's a small mod, I'll handle it manually this time. I have had to
add error handling to the Form_KeyUp sub though - if you're going to
work on more patches like this (and I hope you will), it wouldn't be a
bad idea to read http://www.pgadmin.org/pgadmin2.php?ContentID=8 to get
an idea of how things should look (I can be overly picky sometimes :-)).

Regards, Dave.