Skip site navigation (1) Skip section navigation (2)

Re: SP-GiST for ranges based on 2d-mapping and quad-tree

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SP-GiST for ranges based on 2d-mapping and quad-tree
Date: 2012-11-02 08:47:05
Message-ID: CAPpHfduSGrOK++KvzLpHY0gpRZiNvN6CUXHfK92KEjn3-WwYCg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sun, Oct 21, 2012 at 11:22 AM, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:

> On Tue, 2012-09-04 at 17:45 +0400, Alexander Korotkov wrote:
> > On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql(at)j-davis(dot)com>
> > wrote:
> >         I am taking a look at this patch now. A few quick comments:
> >
> >         * It looks like bounds_adjacent modifies it's by-reference
> >         arguments,
> >         which is a little worrying to me. The lower/upper labels are
> >         flipped
> >         back, but the inclusivities are not. Maybe just pass by value
> >         instead?
> >
> >         * Bounds_adjacent is sensitive to the argument order. Can't it
> >         just take
> >         bound1 and bound2?
> >
> >
> > Fixed. Patch is attached.
> >
> It looks like this is basically the same diff as v0.1. Did something get
> mixed up?
>

Right version of patch is attached.

------
With best regards,
Alexander Korotkov.

Attachment: range_spgist_adjacent-0.3.patch.gz
Description: application/x-gzip (3.8 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Alexander KorotkovDate: 2012-11-02 08:54:33
Subject: Re: gistchoose vs. bloat
Previous:From: Etsuro FujitaDate: 2012-11-02 05:55:57
Subject: Re: Comment typo

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group