Skip site navigation (1) Skip section navigation (2)

Re: Fixed FB 20417

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed FB 20417
Date: 2012-01-10 10:09:42
Message-ID: CANxoLDcUN0DSs-BDWOHwkbUcXqqaJV74m5zb4TbaaxE9cPJcQw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, Jan 10, 2012 at 3:09 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Tue, Jan 10, 2012 at 9:36 AM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
> > On Tue, 2012-01-10 at 14:31 +0530, Akshay Joshi wrote:
> >> Hi Dave
> >>
> >> Modified the logic. Attached is the patch file, please review it.
> >>
> >
> > This is still wrong. bIsChangeComment isn't always true when the user
> > creates a replication cluster. It's only true if there is a comment.
>
> Seems a little long-winded too - can't you just replace the current
> IsEmpty() test with something like "if (txtComment->GetValue() !=
> cluster->GetComment())"?
>

   No, I can't because when we create new Slony I-cluster
"cluster->GetComment()" will not work as cluster object is NULL at that
moment.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246*

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2012-01-10 10:14:36
Subject: Re: Fixed FB 20417
Previous:From: Dave PageDate: 2012-01-10 09:39:45
Subject: Re: Fixed FB 20417

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group