Re: [PATCH] optional cleaning queries stored in pg_stat_statements

On Sat, Nov 5, 2011 at 8:42 PM, Tomas Vondra <tv(at)fuzzy(dot)cz> wrote:
> Dne 6.11.2011 03:16, Peter Geoghegan napsal(a):
>> 2011/11/6 Tomas Vondra <tv(at)fuzzy(dot)cz>:
>>> Hi everyone,
>>
>>> The patch implements a simple "cleaning" that replaces the parameter
>>> values with generic strings - e.g. numbers are turned to ":n", so the
>>> queries mentioned above are turned to
>>>
>>>   SELECT abalance FROM pgbench_accounts WHERE aid = :n
>>>
>>> and thus tracked as a single query in pg_stat_statements.
>>
>> I'm a couple of days away from posting a much better principled
>> implementation of pg_stat_statements normalisation. To normalise, we
>> perform a selective serialisation of the query tree, which is hashed.
>
> OK, my patch definitely is not the only possible and if there's a way to
> get more info from the planner, the results surely might be better. My
> goal was to provide a simple patch that solves the problem better then
> I'll be more than happy to remove mine.

Hi Tomas,

Given Peter's patch on the same subject, should we now mark this one
as rejected in the commitfest app?
https://commitfest.postgresql.org/action/patch_view?id=681

Thanks,

Jeff