Re: One question about security label command

From: Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>
To: hlinnaka(at)iki(dot)fi
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 张元超 <zhangyuanchao(at)highgo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: One question about security label command
Date: 2015-07-12 21:20:15
Message-ID: CAKRt6CTfoo1kwzkEE-mkTnYXyemHA5WB8Q3ECWzzw4KGw6Srcg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen,

> Stephen, would you have the time to review this patch, and commit if
> appropriate, please? And if you could set up the buildfarm animal to run
> this, even better.

I gave this a quick review/test against master (0a0fe2f). Everything
builds and installs as would be expected.

All of the context changes make sense to me. However, I am still
seeing some errors in the regression tests. The errors look like they
are solely based around log messages and not 'functionality'. I have
attached the 'regression.diffs' for reference.

-Adam

--
Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
Database Engineer - www.crunchydatasolutions.com

Attachment Content-Type Size
regression.diffs application/octet-stream 10.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-07-12 21:41:21 Re: Free indexed_tlist memory explicitly within set_plan_refs()
Previous Message Tom Lane 2015-07-12 21:06:33 Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22