Re: Combining Aggregates

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com>
Subject: Re: Combining Aggregates
Date: 2016-03-26 04:24:52
Message-ID: CAKJS1f8d=EetF3xWdWiQvdoJZ8xyK1nS3Q=U9Oy+3LXNFWLkfQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 26 March 2016 at 15:07, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> Ok, so on further look at this I've decided to make changes and have
> it so the serialisation function can be dumb about memory contexts in
> the same way as finalize_aggregate() allows the final function to be
> dumb... notice at the end of the function it copies byref types into
> the correct memory context, if they're not already. So in the attached
> the serialisation function call code now does the same thing. In fact
> I decided to move all that code off into a function called
> finalize_partialaggregate().

Please disregard the previous 0001 patch in favour of the attached one.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Allow-INTERNAL-state-aggregates-to-participate-in-pa_2016-03-26a.patch application/octet-stream 95.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2016-03-26 04:35:05 Re: Alter or rename enum value
Previous Message Regina Obe 2016-03-26 04:06:46 If a schema is created as part of an extension, should all user created tables created in that schema be considered part of the extension?