Skip site navigation (1) Skip section navigation (2)

Re: misspellings & typofixes

From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-docs <pgsql-docs(at)postgresql(dot)org>
Subject: Re: misspellings & typofixes
Date: 2012-04-23 20:30:41
Message-ID: CAK3UJRG6jOAjp3RMox8qAcfEVQKaBHxR9XpEinqBH+kLSENFag@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-docs
On Mon, Apr 23, 2012 at 11:39 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On sön, 2012-04-22 at 21:26 -0700, Josh Kupershmidt wrote:
>> On Sun, Apr 22, 2012 at 9:24 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> > On lör, 2012-04-21 at 10:49 -0700, Josh Kupershmidt wrote:
>> >> On Thu, Apr 12, 2012 at 7:17 PM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
>> >> > Attached is a big patch fixing obvious typos/misspellings.
>> >>
>> >> And here's a separate patch with a few more I turned up.
>> >
>> > Committed.
>>
>> Thanks! [Just to avoid confusion, the first patch is still unapplied].
>
> Uh, just to add to the confusion, I don't see any other similar patch
> from you.


Maybe the list ate it because the patch was too big :-(

Below is my original email, and I'll attach a gzip'ed version of the
original patch instead.
Josh

---------- Forwarded message ----------
From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Date: Thu, Apr 12, 2012 at 7:17 PM
Subject: misspellings & typofixes
To: pgsql-docs <pgsql-docs(at)postgresql(dot)org>


Hi all,

Attached is a big patch fixing obvious typos/misspellings. I'd been
sitting on a few, and also used a script to search out common
errors[1].

While I was mucking around, these two comments caught my eye:

*** a/src/pl/plperl/plperl_helpers.h
--- b/src/pl/plperl/plperl_helpers.h
*************** sv2cstr(SV *sv)
*** 62,68 ****
               (SvTYPE(sv) > SVt_PVLV && SvTYPE(sv) != SVt_PVFM))
               sv = newSVsv(sv);
       else
!               /* increase the reference count so we cant just
SvREFCNT_dec() it when
                * we are done */
               SvREFCNT_inc(sv);

I'm by no means familiar with that code, but perhaps the "cant" in the
comment should be "can"? Ditto for this comment:

*** a/contrib/pgcrypto/pgp-compress.c
--- b/contrib/pgcrypto/pgp-compress.c
*************** compress_init(PushFilter *next, void *in
*** 105,111 ****

 /* writes compressed data packet */

! /* cant handle zero-len incoming data, but shouldnt */
 static int
 compress_process(PushFilter *next, void *priv, const uint8 *data, int len)
 {


(and the contractions in the above comments should use apostrophes, in
any case).

I noticed additional misspellings, e.g.
 * "ficticious", "goverment" and "Ukranian" in ./src/timezone/data/europe
 * "millenium" in ./src/timezone/data/australasia
 * "offical" and "Acording" in ./src/timezone/data/southamerica
 * "sence" in ./src/timezone/data/asia
 * "Antartic" in ./src/timezone/data/antarctica

which I didn't try to fix, as these seem like a problem for IANA upstream.

There are also few instances of dubious lingo, like "wanna" or "thru",
which I also left alone.

Josh

--
[1] I ran through this list:
http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

Attachment: misspellings_cleanup.diff.gz
Description: application/x-gzip (14.2 KB)

In response to

Responses

pgsql-docs by date

Next:From: Aleksey TsalolikhinDate: 2012-04-23 23:43:25
Subject: what is a "working set" ?
Previous:From: Peter EisentrautDate: 2012-04-23 18:39:40
Subject: Re: misspellings & typofixes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group