Skip site navigation (1) Skip section navigation (2)

Re: patch: Allow \dd to show constraint comments

From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: Thom Brown <thom(at)linux(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: patch: Allow \dd to show constraint comments
Date: 2011-09-11 14:11:49
Message-ID: CAK3UJRFqohei37EsW1fHF8qO_ESaAznFV6GiqSruebvmGE7WVw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sat, Sep 10, 2011 at 7:47 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> Just tested this out on current master.  I tried this on every object
> capable of having a comment, and the view reports all of them with the
> correct details.  Doc changes look fine, except for some reason you
> removed a full-stop (period) from after "For all other object types,
> this column is zero."

Thanks for the review. Looks like I got confused about where I was
whacking around in catalogs.sgml, good catch of a spurious change.
Fixed patch attached.

Josh

Attachment: pg_comments.v18.patch
Description: application/octet-stream (70.1 KB)

In response to

pgsql-hackers by date

Next:From: David FetterDate: 2011-09-11 14:25:07
Subject: Re: pg_dump.c
Previous:From: Peter EisentrautDate: 2011-09-11 12:24:36
Subject: Re: [COMMITTERS] pgsql: Add missing format attributes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group