Skip site navigation (1) Skip section navigation (2)

Re: bad examples in pg_dump README

From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bad examples in pg_dump README
Date: 2013-01-09 02:55:07
Message-ID: CAK3UJRFqgYYT1Gqk=UrwwpRvu9_K3fv857_BdvO40VnfVHKH0g@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Mon, Jan 7, 2013 at 8:12 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Sat, 2013-01-05 at 15:34 +0100, Magnus Hagander wrote:
>> On Fri, Jan 4, 2013 at 3:36 AM, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
>> > I propose slimming down the pg_dump README, keeping intact the
>> > introductory notes and details of the tar format.
>>
>> Do we need to keep it at all, really? Certainly the introductory part
>> is covered in the main documentation already...
>
> I'd remove it and distribute the remaining information, if any, between
> the source code and the man page.

Here's a patch to do so. After removing the discussed bogus
information, there were only two notes which I still found relevant,
so I stuck those in the appropriate header comments.

I didn't preserve the comment about "blank username & group" for
tar'ed files, since there are already some comments along these lines
in tarCreateHeader(), and these are "postgres" not "blank" nowadays.
The pg_dump/pg_restore man pages seemed to already do a good enough
job of showing usage examples that I didn't find anything worth adding
there.

Josh

Attachment: pg_dump_README.v2.diff
Description: application/octet-stream (3.8 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2013-01-09 03:37:55
Subject: Re: PL/perl should fail on configure, not make
Previous:From: Tom LaneDate: 2013-01-09 02:42:59
Subject: Re: Index build temp files

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group