On Thu, Sep 1, 2011 at 9:25 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Committed, with some changes. I used the new --if-exists option for
> dropdb rather than doing it as you had it here; I assume this may have
> been the motivation for that patch.
Thanks, and that was indeed one reason I wanted dropdb --if-exists.
> I also just made the exit code 1
> no matter how many failures there were. That seems more normal, and I
> wasn't altogether certain that $((expr)) is completely portable.
Yeah, I wasn't sure about that either. The old book "The Unix
Programming Environment" (section "Arithmetic in sh") claims that
using expr or bc is the only way to do such arithmetic, e.g.:
var=`expr $var + 1`
But then  documents arithmetic expansion as used in the patch. But
anyway, just returning 1 as you've done seems fine.
In response to
pgsql-hackers by date
|Next:||From: Peter Eisentraut||Date: 2011-09-02 22:37:17|
|Subject: Re: pg_upgrade automatic testing|
|Previous:||From: Josh Berkus||Date: 2011-09-02 21:54:53|
|Subject: Re: CF2011-09|