Skip site navigation (1) Skip section navigation (2)

Re: Add statistics_collector_listen_addresses to fix hard-coding of "localhost"

From: Robert Young <yayooo(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Add statistics_collector_listen_addresses to fix hard-coding of "localhost"
Date: 2011-10-27 13:39:40
Message-ID: CAJjz_NhJEMyhEjKRORzA_AbHbbYA3DY+ET8K6actRb6S_w_cfg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugs
In reality,sometimes something would be wrong if you hard-coding 1
minute as 60 seconds.
Please read:
http://www.openbsd.org/cgi-bin/man.cgi?query=strftime
"The range of seconds is (00-60) instead of (00-59) to allow for the
periodic occurrence of leap seconds."

so,it's a bad habit including hard-coding 1 minute as 60 seconds.

On Thu, Oct 27, 2011 at 13:13, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 27.10.2011 15:57, Robert Young wrote:
>>
>> But,I think insistence of hard-coding should be even worse than broken
>> configuration.
>> And hard-coding should never be a good work ethics of a professional
>> programmer.
>
> You're exaggerating. There's nothing wrong hard-coding things like number of
> seconds in a minute (60). While it's not as cast in stone as 60 seconds in a
> minute, I don't see anything wrong with hardcoding that "localhost" means
> the local host.
>
> BTW, do we have anything in place to stop any user on the same host to send
> bogus stat messages to the stats collector?
>
> --
>  Heikki Linnakangas
>  EnterpriseDB   http://www.enterprisedb.com
>

In response to

pgsql-bugs by date

Next:From: JustinDate: 2011-10-27 13:46:17
Subject: BUG #6273: Install Error
Previous:From: Heikki LinnakangasDate: 2011-10-27 13:13:20
Subject: Re: Add statistics_collector_listen_addresses to fix hard-coding of "localhost"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group