Skip site navigation (1) Skip section navigation (2)

Re: pgAgent crashes on failed connection

From: Merlin Moncure <mmoncure(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgAgent crashes on failed connection
Date: 2011-09-28 18:24:09
Message-ID: CAHyXU0wVYq7KFK3FJ-PmT1YCHR1xpx-z78=XQjC_QoURGKR3kw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Wed, Sep 28, 2011 at 2:16 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> (sorry for the late reply, this fell through the cracks..)
>
> On 10.08.2011 11:48, Dave Page wrote:
>>
>> On Thu, Aug 4, 2011 at 8:30 PM, Merlin Moncure<mmoncure(at)gmail(dot)com>  wrote:
>>>
>>> On Thu, Aug 4, 2011 at 2:19 PM, Heikki Linnakangas
>>> <heikki(dot)linnakangas(at)enterprisedb(dot)com>  wrote:
>>>>
>>>> I created 100 identical pgagent jobs, with one step that simply does
>>>> "SELECT
>>>> pg_sleep(10)". I then forced them all to run immediately, with "UPDATE
>>>> pgagent.pga_job SET jobnextrun=now();". pgagent crashed.
>>>>
>>>> What happened is that the when all those jobs are launched at the same
>>>> time,
>>>> the server ran into the max_connections limit, and pgagent didn't handle
>>>> that too well. JobThread::JobThread constructor does not check for NULL
>>>> result from DBConn::Get(), and passes a NULL connection to Job::Job,
>>>> which
>>>> tries to reference it, leading to a segfault.
>>>>
>>>> I propose the attached patch.
>>>
>>> hm, in the event that happens, is that logged in the client somehow?
>>> wouldn't you want to throw an exception or something like that?
>>
>> I think the most straightforward way to handle this is to dump an
>> error into pgagent.pga_joblog when deleting the thread. Might be a
>> little ugly to pass the original error message back rather than a
>> generic one though. Can you take a look Heikki?
>
> You mean something like the attached? Works for me, but inserting an entry
> in joblog for each failed attempt might create a lot of entries there, if
> the problem persists.

Is it correct behavior to throw unhandled sql exception if the logging
query fails?

merlin

In response to

Responses

pgadmin-hackers by date

Next:From: Heikki LinnakangasDate: 2011-09-28 19:16:48
Subject: Re: pgAgent crashes on failed connection
Previous:From: Guillaume LelargeDate: 2011-09-27 07:10:17
Subject: pgAdmin III commit: Fix crash when opening a dlgType

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group