Re: Information for added functionalities

Hi,

I will open individual threads.

Patch 3 "module.mk" explanation:
pgadmin/include/images/module.mk - new file pastetables.png
pgadmin/include/utils/module.mk - new files pasteTables.h and PgadminScanner.h
pgadmin/ui/module.mk - new file frmCopyTables.xrc
pgadmin/utils/module.mk - new file pasteTables.cpp

Best regards
Vladimir Kokovic
Belgrade, Serbia, 23.September 2012

On 9/23/12, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Patch 3 (the only one I've looked at) still modifies at least one
> module.mk file, and it's not appropriate to include part of the
> unrelated settings flush functionality in it. That makes it very hard
> to review the changes individually.
>
> I've also asked a number of times for you to post the patches on
> individual threads. I'm not just asking that to be awkward, but
> because it's hard to keep discussion of each patch separate if they're
> all in the same thread, and makes future searching of the archives
> very difficult.
>
> On Sat, Sep 22, 2012 at 4:49 AM, Vladimir Kokovic
> <vladimir(dot)kokovic(at)gmail(dot)com> wrote:
>> Hi,
>>
>> New patches:
>> patch1.tar.gz - pg_scanner and frmQuery.cpp with multiple result sets
>> support
>> patch2.tar.gz - sysSettings::Flush
>> patch3.tar.gz - copy/paste table(s) with flush server settings to disk
>>
>> Apply patches and build log:
>>
>> root(at)vlD-kuci:/home/src/vlada/vk# ./checkout.sh
>> git clone git://git.postgresql.org/git/pgadmin3.git
>> Cloning into 'pgadmin3'...
>> remote: Counting objects: 130764, done.
>> remote: Compressing objects: 100% (23320/23320), done.
>> remote: Total 130764 (delta 115219), reused 122024 (delta 107013)
>> Receiving objects: 100% (130764/130764), 126.03 MiB | 211 KiB/s, done.
>> Resolving deltas: 100% (115219/115219), done.
>> exit 0
>>
>> root(at)vlD-kuci:/home/src/vlada/vk# cd pgadmin3; patch --context -p1 <
>> /root/files/pgadmin/dave-good/pgadmin3-1.patch; cd ../
>> patching file configure.ac.in
>> patching file pgadmin/Makefile.am
>> patching file pgadmin/db/keywords.c
>> patching file pgadmin/frm/frmQuery.cpp
>> patching file pgadmin/include/frm/frmQuery.h
>> patching file pgadmin/include/parser/keywords.h
>> patching file pgadmin/include/parser/keywords_pgadmin.h
>> patching file pgadmin/include/parser/module.mk
>> patching file pgadmin/include/utils/PgadminScanner.h
>> patching file pgadmin/utils/misc.cpp
>> patching file xtra/Makefile.am
>> patching file xtra/pg_scanners/Makefile.am
>> patching file xtra/pg_scanners/PgadminScanner.c
>> patching file xtra/pg_scanners/PgadminScannerCommon.c
>> patching file xtra/pg_scanners/dummy.c
>> patching file xtra/pg_scanners/mbutils.c
>> patching file xtra/pg_scanners/scan.c
>> patching file xtra/pg_scanners/scan.l
>> patching file xtra/pg_scanners/scansup.c
>> patching file xtra/pg_scanners/src/backend/parser/92/parser/gram.h
>> patching file xtra/pg_scanners/src/backend/parser/keywords.c
>> patching file xtra/pg_scanners/src/backend/parser/kwlookup.c
>> patching file xtra/pg_scanners/src/backend/utils/mb/encnames.c
>> patching file xtra/pg_scanners/src/include/mb/pg_wchar.h
>> patching file xtra/pg_scanners/src/port/chklocale.c
>> patching file xtra/pg_scanners/src/port/pgstrcasecmp.c
>> patching file xtra/pg_scanners/wchar.c
>>
>> root(at)vlD-kuci:/home/src/vlada/vk# cd pgadmin3; patch --context -p1 <
>> /root/files/pgadmin/dave-good/pgadmin3-2.patch; cd ../
>> patching file pgadmin/include/utils/sysSettings.h
>>
>> root(at)vlD-kuci:/home/src/vlada/vk# cd pgadmin3; patch --context -p1 <
>> /root/files/pgadmin/dave-good/pgadmin3-3.patch; cd ../
>> patching file pgadmin/ctl/ctlCheckTreeView.cpp
>> patching file pgadmin/db/pgConn.cpp
>> patching file pgadmin/frm/events.cpp
>> patching file pgadmin/frm/frmMain.cpp
>> patching file pgadmin/include/ctl/ctlCheckTreeView.h
>> patching file pgadmin/include/db/pgConn.h
>> patching file pgadmin/include/frm/frmMain.h
>> patching file pgadmin/include/images/module.mk
>> patching file pgadmin/include/schema/pgTable.h
>> patching file pgadmin/include/schema/pgTrigger.h
>> patching file pgadmin/include/utils/module.mk
>> patching file pgadmin/include/utils/pasteTables.h
>> patching file pgadmin/schema/pgColumn.cpp
>> patching file pgadmin/ui/frmCopyTables.xrc
>> patching file pgadmin/ui/module.mk
>> patching file pgadmin/utils/module.mk
>> patching file pgadmin/utils/pasteTables.cpp
>>
>> root(at)vlD-kuci:/home/src/vlada/vk# cp
>> /root/files/pgadmin/dave-good/pastetables.png
>> pgadmin3/pgadmin/include/images
>>
>> root(at)vlD-kuci:/home/src/vlada/vk# ./build-debug.sh
>> set -e
>> rm -rf debug
>> mkdir debug
>> cd pgadmin3
>> bash bootstrap
>> Checking aclocal...
>> Checking automake...
>> Stamping the version number...
>> Configuring the build system...
>> + aclocal-1.11
>> + autoheader
>> + automake-1.11 --foreign --add-missing --copy
>> + autoconf
>> cd ./pgadmin
>> ./ver_svn.sh
>> cd ../../debug
>> export CXXFLAGS="-gdwarf-2 -g3"
>> ../pgadmin3/configure --prefix=/usr/local/pgadmin3-debug
>> --enable-debug --enable-databasedesigner --srcdir=../pgadmin3
>> --with-pgsql=/home/src/postgresql-devel/20120502 >
>> configure-out-debug.log 2>&1
>> make > make-out-debug.log 2>&1
>> # make install > make-install-out-debug.log 2>&1
>> exit 0
>>
>>
>> Best regards
>> Vladimir Kokovic
>> Belgrade, Serbia, 22.September 2012
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>