| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Date: | 2015-09-15 14:24:14 |
| Message-ID: | CAHGQGwHHAx9i=O8iKV+PfANG7X9dLMspOc-Sd1zvs+vgUQAaqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Sep 11, 2015 at 1:57 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Sep 11, 2015 at 10:10 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> So I added the object type, i.e., file in this case, to the errdetail
>> messages. Attached is the updated version of the patch.
>>
>> I also changed other log messages related to tablespace_map
>> so that they follow the style guide.
>>
>
> Looks good to me.
Thanks for the review! Applied.
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2015-09-15 14:38:19 | pgsql: Fix comment regarding the meaning of infinity for timeline histo |
| Previous Message | Fujii Masao | 2015-09-15 14:23:46 | pgsql: Improve log messages related to tablespace_map file |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jesper Pedersen | 2015-09-15 14:27:45 | Additional LWLOCK_STATS statistics |
| Previous Message | Stephen Frost | 2015-09-15 14:22:34 | Re: RLS open items are vague and unactionable |