Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Phil Sorber <phil(at)omniti(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pg_isready (was: [WIP] pg_ping utility)
Date: 2013-06-02 17:14:38
Message-ID: CAHGQGwH-Zb2obt_GhzMwXEasrB7JWCWH_K9vJXsVP_RmCVRpPg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Sorry for the delay in responding to you.

On Mon, Feb 11, 2013 at 6:03 AM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> On Fri, Feb 8, 2013 at 1:07 PM, Phil Sorber <phil(at)omniti(dot)com> wrote:
>> On Fri, Feb 8, 2013 at 12:46 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> No maybe. But I think that all the client commands should follow the
>>> same rule. Otherwise a user would get confused when specifying
>>> options.
>>
>> I would consider the rest of the apps using it as a consensus. I will
>> make sure it aligns in behavior.
>>
>
> I've done as you suggested, and made sure they align with other
> command line utils. What I have found is that dbname is passed
> (almost) last in the param array so that it clobbers all previous
> values. I have made this patch as minimal as possible basing it off of
> master and not off of my previous attempt. For the record I still like
> the overall design of my previous attempt better, but I have not
> included a new version based on that here so as not to confuse the
> issue, however I would gladly do so upon request.
>
> Updated patch attached.

Thanks! The patch basically looks good to me.

I updated the patch against current master and fixed some problems:

- Handle the hostaddr in the connection string properly.
- Remove the character 'V' from the third argument of getopt_long().
- Handle the error cases of PQconninfoParse() and PQconndefaults().
- etc...

Please see the attached patch.

Regards,

-- 
Fujii Masao

Attachment: pg_isready_con_str_v5.patch
Description: application/octet-stream (5.0 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Jeff JanesDate: 2013-06-02 18:44:04
Subject: Vacuum, Freeze and Analyze: the big picture
Previous:From: C├ędric VillemainDate: 2013-06-02 13:53:31
Subject: Re: PostgreSQL 9.3 beta breaks some extensions "make install"

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group