Re: [COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.

On Sat, Apr 14, 2012 at 4:16 AM, Thom Brown <thom(at)linux(dot)com> wrote:
> On 13 April 2012 19:15, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>
>>> In my view, remote_write seems a lot more clear than write
>>
>> +1
>>
>> I sure didn't understand it to mean remote_write when I read the
>> subject line.
>
> Whatever this option value is named, it needs to be referenced in the
> postgresql.conf comment for this option, as it isn't currently.

Yes. The patch I've posted does this.

> I have a question though.  What happens when this is set to "write"
> (or "remote_write" as proposed) but it's being used on a standalone
> primary?  At the moment it's not documented what level of guarantee
> this would provide.

http://www.postgresql.org/docs/devel/static/warm-standby.html#SYNCHRONOUS-REPLICATION-HA
-----------------
Commits made when synchronous_commit is set to on or write will
wait until the synchronous standby responds. The response may
never occur if the last, or only, standby should crash.
-----------------

Is this description not enough? If not enough, how should we change
the document?

Regards,

--
Fujii Masao