Re: WAL Restore process during recovery

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WAL Restore process during recovery
Date: 2012-01-20 03:43:17
Message-ID: CAHGQGwFcxP6rrtGN4kHSurzGcZV24H3GFpA=VwGwQ0seO5TO4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 20, 2012 at 4:17 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Tue, Jan 17, 2012 at 6:52 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Mon, Jan 16, 2012 at 2:06 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> WALRestore process asynchronously executes restore_command while
>>> recovery continues working.
>>>
>>> Overlaps downloading of next WAL file to reduce time delays in file
>>> based archive recovery.
>>>
>>> Handles cases of file-only and streaming/file correctly.
>>
>> Though I've not reviewed the patch deeply yet, I observed the following
>> two problems when I tested the patch.
>>
>> When I set up streaming replication + archive (i.e., restore_command is set)
>> and started the standby, I got the following error:
>>
>>    FATAL:  all AuxiliaryProcs are in use
>>    LOG:  walrestore process (PID 18839) exited with exit code 1
>
> Fixed and better documented.
>
>> When I started an archive recovery without setting restore_command,
>> it successfully finished.
>
> Not sure exactly what you mean, but I fixed a bug that might be
> something you're seeing.

Thanks!

But you forgot to include walrestore.c and .h in the patch. Can you submit
the updated version of the patch?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2012-01-20 03:46:54 Re: Group commit, revised
Previous Message Nikhil Sontakke 2012-01-20 03:38:33 Re: Review of patch renaming constraints