| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add missing format attributes |
| Date: | 2011-09-11 07:11:57 |
| Message-ID: | CAHGQGwFVb8VsfA+H75+XcNMb6tGtRxEz4gW4BHzMhk2j9J92dA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Sep 11, 2011 at 5:17 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Add missing format attributes
>
> Add __attribute__ decorations for printf format checking to the places that
> were missing them. Fix the resulting warnings. Add
> -Wmissing-format-attribute to the standard set of warnings for GCC, so these
> don't happen again.
>
> The warning fixes here are relatively harmless. The one serious problem
> discovered by this was already committed earlier in
> cf15fb5cabfbc71e07be23cfbc813daee6c5014f.
This commit causes the following warning at the compile time.
error.c: In function 'ecpg_raise_backend':
error.c:339: warning: field precision should have type 'int', but
argument 2 has type 'long unsigned int'
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2011-09-11 12:23:15 | pgsql: Fix additional format warning |
| Previous Message | Bruce Momjian | 2011-09-10 22:24:08 | Re: pgsql: /contrib/foo -> contrib/foo |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2011-09-11 07:30:18 | Re: [REVIEW] prepare plans of embedded sql on function start |
| Previous Message | Tom Lane | 2011-09-11 05:21:00 | Re: [REVIEW] prepare plans of embedded sql on function start |