Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add missing format attributes

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add missing format attributes
Date: 2011-09-11 07:11:57
Message-ID: CAHGQGwFVb8VsfA+H75+XcNMb6tGtRxEz4gW4BHzMhk2j9J92dA@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Sun, Sep 11, 2011 at 5:17 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Add missing format attributes
>
> Add __attribute__ decorations for printf format checking to the places that
> were missing them.  Fix the resulting warnings.  Add
> -Wmissing-format-attribute to the standard set of warnings for GCC, so these
> don't happen again.
>
> The warning fixes here are relatively harmless.  The one serious problem
> discovered by this was already committed earlier in
> cf15fb5cabfbc71e07be23cfbc813daee6c5014f.

This commit causes the following warning at the compile time.

error.c: In function 'ecpg_raise_backend':
error.c:339: warning: field precision should have type 'int', but
argument 2 has type 'long unsigned int'

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

pgsql-hackers by date

Next:From: Pavel StehuleDate: 2011-09-11 07:30:18
Subject: Re: [REVIEW] prepare plans of embedded sql on function start
Previous:From: Tom LaneDate: 2011-09-11 05:21:00
Subject: Re: [REVIEW] prepare plans of embedded sql on function start

pgsql-committers by date

Next:From: Peter EisentrautDate: 2011-09-11 12:23:15
Subject: pgsql: Fix additional format warning
Previous:From: Bruce MomjianDate: 2011-09-10 22:24:08
Subject: Re: pgsql: /contrib/foo -> contrib/foo

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group