Re: xlog location arithmetic

On Tue, Dec 6, 2011 at 1:19 PM, Euler Taveira de Oliveira
<euler(at)timbira(dot)com> wrote:
> Hi,
>
> A while ago when blogging about WAL [1], I noticed a function to deal with
> xlog location arithmetic is wanted. I remembered Depez [2] mentioning it and
> after some questions during trainings and conferences I decided to translate
> my shell script function in C.
>
> The attached patch implements the function pg_xlog_location_diff (bikeshed
> colors are welcome). It calculates the difference between two given
> transaction log locations. Now that we have pg_stat_replication view, it will
> be easy to get the lag just passing columns as parameters. Also, the
> monitoring tools could take advantage of it instead of relying on a fragile
> routine to get the lag.
>
> I noticed that pg_xlogfile_name* functions does not sanity check the xrecoff
> boundaries but that is material for another patch.
>
>
> [1] http://eulerto.blogspot.com/2011/11/understanding-wal-nomenclature.html
> [2]
> http://www.depesz.com/index.php/2011/01/24/waiting-for-9-1-pg_stat_replication/

I think that this function is very useful. Can you add the patch into
CommitFest 2012-1 ?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center