| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Your review of pg_receivexlog/pg_basebackup |
| Date: | 2011-10-28 06:46:49 |
| Message-ID: | CAHGQGwE3DL1QO39rga2R0=Dw5xEWKUa6B6OYAjsaTY4GAHEXPQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 27, 2011 at 11:14 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Here's a version that does this. Turns out this requires a lot less
> code than what was previously in there, which is always nice.
>
> We still need to solve the other part which is how to deal with the
> partial files on restore. But this is definitely a cleaner way from a
> pure pg_receivexlog perspective.
>
> Comments/reviews?
Looks good.
Minor comment:
the source code comment of FindStreamingStart() seems to need to be updated.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2011-10-28 06:56:46 | Re: Updated version of pg_receivexlog |
| Previous Message | Magnus Hagander | 2011-10-28 06:12:54 | Re: pg_upgrade if 'postgres' database is dropped |