| From: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Rahila Syed <rahilasyed(dot)90(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [REVIEW] Re: Compression of full-page-writes |
| Date: | 2014-07-04 13:57:10 |
| Message-ID: | CAH2L28vSN+pzLqCDhiupiVhpGnWuneV5=AX0AZG4pcKUyhzaSQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> But 0002-CompressBackupBlock_snappy_lz4_pglz-2.patch doesn't seem to
> be able to apply to HEAD cleanly.
>Yes, and it needs quite some reformatting beyond fixing whitespace
>damage too (long lines, comment formatting, consistent spacing etc.).
Please find attached patches with no whitespace error and improved
formatting.
Thank you,
On Fri, Jul 4, 2014 at 11:39 AM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
wrote:
> At 2014-07-04 14:38:27 +0900, masao(dot)fujii(at)gmail(dot)com wrote:
> >
> > But 0002-CompressBackupBlock_snappy_lz4_pglz-2.patch doesn't seem to
> > be able to apply to HEAD cleanly.
>
> Yes, and it needs quite some reformatting beyond fixing whitespace
> damage too (long lines, comment formatting, consistent spacing etc.).
>
> -- Abhijit
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Support-for-LZ4-and-Snappy-2.patch | application/octet-stream | 140.8 KB |
| 0002-CompressBackupBlock_snappy_lz4_pglz-2.patch | application/octet-stream | 10.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | MauMau | 2014-07-04 13:59:15 | [RFC: bug fix?] Connection attempt block forever when the synchronous standby is not running |
| Previous Message | Abhijit Menon-Sen | 2014-07-04 13:41:56 | Re: [PATCH] introduce XLogLockBlockRangeForCleanup() |