Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

On Mon, Apr 16, 2012 at 3:03 PM, Sachin Srivastava <
sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:

>
> Ashesh,
>
> In this code block,
>
> 360 +
> (function->GetArgModesArray()[index] == wxT("INOUT") &&
> 361 + lanname != wxT("edbsql")) ||
> 362 +
> function->GetArgModesArray()[index] == wxT("VARIADIC"))
>
Sachin,

Thanks for the review.

Dave,

Please find the updated patches.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>

>
>
> lanname should be comapred to 'edbspl'.
>
> Rest all looks good.
>
>
> On Mon, Apr 9, 2012 at 12:45 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> During resolving a bug - "Error message is displayed when the packages is
>> clicked", I found that:
>> - We are not properly handling the default parameters for the functions &
>> procedures properly, when the function is type of 'edbspl'.
>> - We also do not handle the default parameters for the functions &
>> procedures properly under the packages.
>>
>> In 'edbspl', we do not allow the default parameters with INOUT parameters
>> and that reflects in the reverse-engineering for those functions &
>> procedures.
>>
>> Attached patches resolve the above issues for REL-1_14 and master
>> branches.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Regards,
> Sachin Srivastava
> EnterpriseDB, India
>