Re: Fixed issue "Error Message is displayed when the Package is Clicked"

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixed issue "Error Message is displayed when the Package is Clicked"
Date: 2012-03-20 08:47:51
Message-ID: CAG7mmoykM3hNP782dMuHkDtJ4dyLh+f4Wtu2qkQU+zTt+M1-FA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Mar 20, 2012 at 2:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Tue, Mar 20, 2012 at 7:35 AM, Ashesh Vashi
> <ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Reason for the error:
> >
> > REL-9_1_STABLE branch (PostgreSQL repository):
> >
> > commit 303696c3b47e6719e983e93da5896ddc4a2e0dbb
> > Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> > Date: Fri Sep 3 01:34:55 2010 +0000
> >
> > Install a data-type-based solution for protecting pg_get_expr().
> >
> > Since the code underlying pg_get_expr() is not secure against
> malformed
> > input, and can't practically be made so, we need to prevent
> miscreants
> > from feeding arbitrary data to it. We can do this securely by
> declaring
> > pg_get_expr() to take a new datatype "pg_node_tree" and declaring the
> > system catalog columns that hold nodeToString output to be of that
> type.
> > There is no way at SQL level to create a non-null value of type
> > pg_node_tree.
> > Since the backend-internal operations that fill those catalog columns
> > operate below the SQL level, they are oblivious to the datatype
> > relabeling
> > and don't need any changes.
>
> Oh yeah, I vaguely remember that. Surely that wasn't back ported to
> 9.0 though? Akshay said he sees the issue there as well (which I
> don't).
>
Certainly not in PostgreSQL 9.0.
I can't find those changes in PPAS.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/>

*http://www.linkedin.com/in/asheshvashi*

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2012-03-20 09:27:26 Re: Fixed issue "Error Message is displayed when the Package is Clicked"
Previous Message Dave Page 2012-03-20 08:37:29 Re: Fixed issue "Error Message is displayed when the Package is Clicked"