Skip site navigation (1) Skip section navigation (2)

Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)
Date: 2012-04-16 12:53:59
Message-ID: CAG7mmoxeSiPTJcxxaj0GEtaz4-8r5wN6OTryzTyVHn4gYYLs9g@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, Apr 16, 2012 at 5:36 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks - I've applied and pushed the patch for master

Thanks!

> , but the REL-1_14 version doesn't apply.
>
> error: patch failed: pgadmin/schema/pgFunction.cpp:808
> Applied patch pgadmin/schema/edbPackageFunction.cpp cleanly.
> Applying patch pgadmin/schema/pgFunction.cpp with 2 rejects...
> Hunk #1 applied cleanly.
> Hunk #2 applied cleanly.
> Hunk #3 applied cleanly.
> Hunk #4 applied cleanly.
> Hunk #5 applied cleanly.
> Hunk #6 applied cleanly.
> Hunk #7 applied cleanly.
> Hunk #8 applied cleanly.
> Rejected hunk #9.
> Rejected hunk #10
>
> Please fix and resubmit that version. Thanks!
>
Please find the updated patch.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/>



*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>


>
> On Mon, Apr 16, 2012 at 9:52 AM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>  On Mon, Apr 16, 2012 at 3:03 PM, Sachin Srivastava <
>> sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
>>
>>>
>>> Ashesh,
>>>
>>> In this code block,
>>>
>>> 360 +
>>> (function->GetArgModesArray()[index] == wxT("INOUT") &&
>>> 361 +                                        lanname != wxT("edbsql")) ||
>>> 362 +
>>> function->GetArgModesArray()[index] == wxT("VARIADIC"))
>>>
>> Sachin,
>>
>> Thanks for the review.
>>
>> Dave,
>>
>> Please find the updated patches.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/>
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>
>>
>>>
>>>
>>> lanname should be comapred to 'edbspl'.
>>>
>>> Rest all looks good.
>>>
>>>
>>> On Mon, Apr 9, 2012 at 12:45 PM, Ashesh Vashi <
>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> During resolving a bug - "Error message is displayed when the packages
>>>> is clicked", I found that:
>>>> - We are not properly handling the default parameters for the functions
>>>> & procedures properly, when the function is type of 'edbspl'.
>>>> - We also do not handle the default parameters for the functions &
>>>> procedures properly under the packages.
>>>>
>>>> In 'edbspl', we do not allow the default parameters with INOUT
>>>> parameters and that reflects in the reverse-engineering for those functions
>>>> & procedures.
>>>>
>>>> Attached patches resolve the above issues for REL-1_14 and master
>>>> branches.
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com>
>>>>
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi>
>>>>
>>>>
>>>>
>>>> --
>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>
>>>>
>>>
>>>
>>> --
>>> Regards,
>>> Sachin Srivastava
>>> EnterpriseDB, India
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

Attachment: FB20547_REL_1_14_v2.patch
Description: application/octet-stream (15.6 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2012-04-16 13:58:25
Subject: pgAdmin III commit: Fix handling of parameter handling for edbsplfunct
Previous:From: Dave PageDate: 2012-04-16 12:06:03
Subject: Re: PATCH: Error Message is displayed when the Package is Clicked in pgAdmin (having functions with default parameters)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group