Re: [PATCH] Improve autocompletion for SELECT statements

From: Wander Winkelhorst <w(dot)winkelhorst(at)gmail(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Improve autocompletion for SELECT statements
Date: 2011-11-10 21:51:28
Message-ID: CAFv2D8tLx-BriA+C+_ED7h9NGDas1Gh5+fpJfGRndrj=k8b1rg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Tue, Nov 1, 2011 at 4:31 PM, Guillaume Lelarge <guillaume(at)lelarge(dot)info>wrote:

>
> OK, it works now. I understand a lot of improvements could come later,
> but there is one thing that bugs me. And I think it should be fixed
> before applying.
>
> Let's say I wrote this:
>
> SELECT * FROM person JOIN company ON
>
> and try autocompletion afterwards. I get the list of columns in person
> and company, which is great. The issue is that you only have the
> column's name, not the table's name. So you don't know if the column
> refers to the first table or the second. We could say it's not an issue
> if we were sure they were all different. But if I have two times the id
> column, it gets kinda weird. Maybe you should show the table's name in
> front of the column's name.
>

Allright, another week, another patch :-)

Changes since last time:
- Support for aliasses (autocompletion on "select * from person p join
company c on ...) will present a list of "p.id, p.name, c.id, c.name etc.)
- Support for queries without aliasses (select * from person where ...)
- Support for queries without aliasses but with joins (select * from person
join company on ...)
- Support for queries with mixed versions (select * from person p join
company on ...)
- Support for update statements (update person set ...)
- Support for autocompletion after SELECT (select ... from person)
- Fixed a crash

Regards,
Wander Winkelhorst.

Attachment Content-Type Size
autocomplete.patch text/x-patch 10.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2011-11-12 22:56:53 pgAdmin III commit: Update french translation
Previous Message Dave Page 2011-11-10 09:13:20 Re: Git Trunk Build Issue