Skip site navigation (1) Skip section navigation (2)

Re: proposal: fix corner use case of variadic fuctions usage

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Vik Reykja <vikreykja(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: fix corner use case of variadic fuctions usage
Date: 2012-12-01 12:14:08
Message-ID: CAFj8pRDyXfXZcL2FRESLU-dPqaOKOu-ekKY12tBzdO559PW5uQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-hackers
Hello

>
> Hi Pavel.
>
> I am trying to review this patch and on my work computer everything compiles
> and tests perfectly. However, on my laptop, the regression tests don't pass
> with "cache lookup failed for type XYZ" where XYZ is some number that does
> not appear to be any type oid.
>
> I don't really know where to go from here. I am asking that other people try
> this patch to see if they get errors as well.
>

yes, I checked it on .x86_64 and I had a same problems

probably there was more than one issue - I had to fix a creating a
unpacked params and I had a issue with gcc optimalization when I used
a stack variable for fcinfo.

Now I fixed these issues and I hope  so it will work on all platforms

Regards

Pavel Stehule




> Vik
>
> PS: I won't be able to answer this thread until Tuesday.
>

Attachment: variadic_argument_for_variadic_any_function_20121201.diff
Description: application/octet-stream (16.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2012-12-01 12:43:17
Subject: Re: --single-transaction hack to pg_upgrade does not work
Previous:From: Erik RijkersDate: 2012-12-01 11:22:56
Subject: Re: WIP: index support for regexp search

pgsql-general by date

Next:From: Magnus HaganderDate: 2012-12-01 13:43:26
Subject: Re: pg_basebackup questions
Previous:From: John R PierceDate: 2012-11-30 21:46:50
Subject: Re: difference in query performance due to the inclusion of a polygon geometry field

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group