| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: bytea_agg |
| Date: | 2011-12-23 18:23:13 |
| Message-ID: | CAFj8pRC2mh7fUY6oAu8rObjG4i4zhDU_VkLg2JMh_vvbAxPWXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
2011/12/23 Peter Eisentraut <peter_e(at)gmx(dot)net>:
> On ons, 2011-12-21 at 11:04 +0100, Pavel Stehule wrote:
>> this patch adds a bytea_agg aggregation.
>>
>> It allow fast bytea concatetation.
>
> Why not call it string_agg? All the function names are the same between
> text and bytea (e.g., ||, substr, position, length). It would be nice
> not to introduce arbitrary differences.
My opinion is not too strong. I don't think so using string_agg is
good name (for bytea_agg) - as minimal (and only one) reason is
different API - there is no support for delimiter. If I remember well
discussion about string_agg, where delimiter is not optimal, there is
request for immutable interface for aggregates - there was a issue
with ORDER clause. So bytea_agg is good name.
Regards
Pavel
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2011-12-23 18:25:07 | Re: patch: bytea_agg |
| Previous Message | Peter Eisentraut | 2011-12-23 17:51:38 | Re: patch: bytea_agg |