| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PL/pgSQL, RAISE and error context |
| Date: | 2015-08-13 06:24:21 |
| Message-ID: | CAFj8pRBeO+Z_LL-fT30rOp5V4-5LzM+Ur+gMizcD-CEZfP++dQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
2015-08-12 11:07 GMT+02:00 Marko Tiikkaja <marko(at)joh(dot)to>:
> On 8/12/15 9:36 AM, Pavel Stehule wrote:
>
>> So, there is common agreement on this version.
>>
>
> There are several instances of double semicolons. Also,
> PsqlSettings.show_context doesn't look like a boolean to me. For
> SHOW_CONTEXT, it would be good if the documentation mentioned the default
> value.
>
> I'm somewhat worried that this is hiding important context from some
> NOTICE or WARNING messages intended for novice users, but probably not
> worried enough to go through all of them. +3/8 from me, I guess.
>
I fixed mentioned issues.
Regards
Pavel
>
>
> .m
>
| Attachment | Content-Type | Size |
|---|---|---|
| libpq-context-filter-20150813-01.patch.gz | application/x-gzip | 15.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-08-13 06:31:37 | Re: Test code is worth the space |
| Previous Message | Magnus Hagander | 2015-08-13 06:23:19 | Re: Test code is worth the space |