Skip site navigation (1) Skip section navigation (2)

Re: review: CHECK FUNCTION statement

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Petr Jelínek <pjmodos(at)pjmodos(dot)net>, Greg Smith <greg(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Subject: Re: review: CHECK FUNCTION statement
Date: 2012-02-29 13:37:48
Message-ID: CAFj8pRAc5fqZ+Ww5QBG9+ZQCP5dY+BTd4aztd4v+Cyn5rVqsjg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Hello

2012/2/28 Alvaro Herrera <alvherre(at)commandprompt(dot)com>:
>
>
> In gram.y we have a new check_option_list nonterminal.  This is mostly
> identical to explain_option_list, except that the option args do not
> take a NumericOnly (only opt_boolean_or_string and empty).  I wonder if
> it's really worthwhile having a bunch of separate productions for this;
> how about we just use the existing explain_option_list instead and get
> rid of those extra productions?
>
> elog() is used in many user-facing messages (errors and notices).  Full
> ereport() calls should be used there, so that messages are marked for
> translations and so on.

I replaced elog by ereport for all not internal errors

>
> Does the patched pg_dump work with older servers?
>

it should to do

> I don't like CheckFunction being declared in defrem.h.  It seems
> completely out of place there.  I don't see any better place though, so
> I'm thinking maybe we should have a new header file for it (say
> commands/functions.h; but we already have executor/functions.h so
> perhaps it's better to find another name).  This addition means that
> there's a distressingly large number of .c files that are now getting
> dest.h, which was previously pretty confined.

please, fix it like you wish

Regards

Pavel

>
> --
> Álvaro Herrera <alvherre(at)commandprompt(dot)com>
> The PostgreSQL Company - Command Prompt, Inc.
> PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Attachment: check_function-2012-02-29-1.diff.gz
Description: application/x-gzip (29.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Heikki LinnakangasDate: 2012-02-29 13:56:43
Subject: Re: SSI rw-conflicts and 2PC
Previous:From: Fujii MasaoDate: 2012-02-29 10:48:36
Subject: Unnecessary WAL archiving after failover

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group