Re: review: CHECK FUNCTION statement

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: review: CHECK FUNCTION statement
Date: 2011-12-15 11:36:24
Message-ID: CAFj8pRA33hE+2y59jeww-0c2iFfvF6FhTv0fXA5npH2WKjOcwg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

2011/12/15 Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>:
> Pavel Stehule wrote:
>> so removed "quite" option
>> and removed multiple check regression tests also - there is missing
>> explicit order of function checking, so regress tests can fail :(
>
> There seems to be a problem with the SET clause of CREATE FUNCTION:
>
> ftest=# CREATE OR REPLACE FUNCTION a(integer) RETURNS integer
>        LANGUAGE plpgsql AS 'BEGIN RETURN 2*$1; END';
> CREATE FUNCTION
> ftest=# CHECK FUNCTION a(integer);
> NOTICE:  checked function "a(integer)"
> CHECK FUNCTION
> ftest=# CREATE OR REPLACE FUNCTION a(integer) RETURNS integer
>        LANGUAGE plpgsql SET search_path=public AS 'BEGIN RETURN 2*$1; END';
> CREATE FUNCTION
> ftest=# CHECK FUNCTION a(integer);
> The connection to the server was lost. Attempting reset: Failed.
> !>
>

There was bug - missing detoast call

fixed

Regards

Pavel

> Yours,
> Laurenz Albe

Attachment Content-Type Size
check_function-2011-12-15-1.diff.gz application/x-gzip 25.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2011-12-15 11:54:57 Re: includeifexists in configuration file
Previous Message Albe Laurenz 2011-12-15 09:38:55 Re: review: CHECK FUNCTION statement