Skip site navigation (1) Skip section navigation (2)

review: psql tab completion for GRANT role

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: review: psql tab completion for GRANT role
Date: 2012-01-17 12:03:50
Message-ID: CAFj8pRA+OzQ5ghE9Z2FJ5knYMb1JJiFjY-L1k-4WUmMSJrtAKw@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Hello

I did review of this small patch
http://archives.postgresql.org/message-id/1326055692.15293.15.camel@vanquo.pezone.net

* This patch was applied without with one hunk and compiled without warnings

bash-4.2$ patch -p1 < autocompleta.patch
patching file src/bin/psql/tab-complete.c
Hunk #2 succeeded at 2335 with fuzz 1.

* all regress tests was processed

* this patch respect Pg coding standards
* code is simple and has not impact on core functionality or core performance
* regress tests are not requested for interactive function
* I checked it, and autocomplete has expected behave.

It is ready for commit

Regards

Pavel Stehule

Responses

pgsql-hackers by date

Next:From: Susanne EbrechtDate: 2012-01-17 12:18:53
Subject: Re: 9.3 feature proposal: vacuumdb -j #
Previous:From: Heikki LinnakangasDate: 2012-01-17 11:24:37
Subject: Re: BGWriter latch, power saving

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group