Skip site navigation (1) Skip section navigation (2)

Re: Review: Non-inheritable check constraints

From: Alex Hunsaker <badalex(at)gmail(dot)com>
To: Nikhil Sontakke <nikkhils(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: Non-inheritable check constraints
Date: 2011-10-09 06:40:36
Message-ID: CAFaPBrS2J0HnsxckVWMMptA4B0MSnTpNM8Rb7FMjYfPd6Q4tLQ@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Fri, Oct 7, 2011 at 21:30, Nikhil Sontakke <nikkhils(at)gmail(dot)com> wrote:
> Hi Alex,
>
> I guess we both are in agreement with each other :)
>
> After sleeping over it, I think that check is indeed dead code with this new
> non-inheritable check constraints functionality in place. So unless you have
> some other comments, we can mark this as 'Ready for Commiter'.
>
> Again, thanks for the thorough review and subsequent changes!

PFA an updated patch with the check removed and a comment or two added.

I've also marked it ready.

Attachment: non_inh_check_v3.patch.gz
Description: application/x-gzip (7.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Florian PflugDate: 2011-10-09 10:45:08
Subject: Re: libpq, PQdescribePrepared -> PQftype, PQfmod, no PQnullable
Previous:From: Tom LaneDate: 2011-10-09 04:34:26
Subject: Re: Intermittent regression test failure from index-only scans patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group