| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Ali Dar <ali(dot)munir(dot)dar(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: missing rename support |
| Date: | 2013-02-03 15:04:48 |
| Message-ID: | CAEZATCVaSsSi5LNAwQUCpAP7mHt4mYZq_Z6yRFs_Q_NtwxiwWA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29 January 2013 15:34, Ali Dar <ali(dot)munir(dot)dar(at)gmail(dot)com> wrote:
> Please find attached the complete patch for alter rename rule. I have
> followed all the suggestions.
This looks good. I've tested it, and it appears to work as intended.
I'm happy with the code, and the new docs and regression tests look
OK.
I have a couple of minor tweaks (see attached):
* On the new manual page, I replaced "table" with "table or view".
* In the new tab-completion code, I modified the query so that it
completes with tables as well as views, and limited the results to
just those relations that have a rule with the name specified,
otherwise the list of completions could be very long.
If you're happy with these changes, I think this is ready for committer review.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| alter-rule-rename_complete.v2.patch | application/octet-stream | 14.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-02-03 16:17:42 | Re: autovacuum not prioritising for-wraparound tables |
| Previous Message | Phil Sorber | 2013-02-03 07:23:05 | Re: [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq |