| From: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Jay Levitt <jay(dot)levitt(at)gmail(dot)com>, "Jim Decibel! Nasby" <decibel(at)decibel(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Progress on fast path sorting, btree index creation time |
| Date: | 2012-02-09 15:36:23 |
| Message-ID: | CAEYLb_Vc0ovDG+3vghF0ZeiCs1qAMBbZ9f4eG62mp=pnFHGGcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9 February 2012 14:51, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I'm not sure I entirely follow all this, but I'll look at the code
> once you have it. Are you saying that all the comparetup_yadda
> functions are redundant to each other in the single-key case?
Yes, I am. The main reason that the loops exist in those functions
(which is the only way that they substantially differ) is because they
each have to get the other keys through various ways that characterise
the tuple class that they encapsulate (index_getattr(),
heap_getattr(), etc).
--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2012-02-09 16:18:21 | Notify system doesn't recover from "No space" error |
| Previous Message | Tom Lane | 2012-02-09 15:17:59 | Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram. |