From:
Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To:
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: ALTER command reworks
Date:
2013-01-15 15:40:29
Message-ID:
CADyhKSV_gbTKy71EdxT-9PqyuVHOJ7phcf+yTJ47ZuNV7OhUDw@mail.gmail.com (view raw or flat )
Thread:
2012-07-24 05:24:11 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-08-13 19:35:58 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-08-30 19:24:06 from Robert Haas <robertmhaas(at)gmail(dot)com>
2012-08-31 04:27:34 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-09-10 11:08:32 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-09-27 20:38:04 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-09-28 21:17:32 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-10-02 14:19:17 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-10-06 18:58:24 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-10-03 21:25:54 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-10-03 21:28:00 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-10-05 14:50:43 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-10-06 20:16:12 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-10-17 20:09:24 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-11-15 18:44:46 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-11-19 14:58:10 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-11-19 15:25:09 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-11-19 15:39:27 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-11-19 16:34:33 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-11-30 22:07:23 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2012-12-03 10:27:40 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2013-01-07 20:43:28 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-01-07 20:50:38 from Robert Haas <robertmhaas(at)gmail(dot)com>
2013-01-07 21:06:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2013-01-07 21:14:32 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2013-01-07 21:58:52 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-01-09 11:46:37 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2013-01-15 15:06:12 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-01-15 15:40:29 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2013-01-15 15:49:52 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-01-17 00:13:22 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2013-01-17 21:59:03 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-01-19 22:48:50 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2013-01-20 16:28:24 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2013-01-21 15:12:16 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2013-02-03 21:57:27 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2013-02-04 05:02:24 from Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
2013-02-04 14:23:31 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Lists:
pgsql-hackers
2013/1/15 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Kohei KaiGai escribió:
>
>> The attached patch is a rebased version towards the latest master
>> branch, and fix up the issue around error messages on name conflicts.
>
> I assume the lock.c changes are just a bollixed merge, right?
>
Yes, I'll check it and rebase it.
> I am not sure about some of the changes in the regression test expected
> output; are we really okay with losing the "in schema foo" part in some
> of these cases?
>
The changes in the expected results in regression test originated from
elimination of getObjectDescription, but "in schema foo" should be kept.
It looks like an obvious my mistake. Sorry.
Thanks,
--
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>
In response to
Responses
pgsql-hackers by date
Next :From: Andres FreundDate: 2013-01-15 15:49:22Subject : Re: logical changeset generation v4Previous :From : Tom LaneDate : 2013-01-15 15:28:28Subject : Re: logical changeset generation v4
