Skip site navigation (1) Skip section navigation (2)

Re: recent ALTER whatever .. SET SCHEMA refactoring

From: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: recent ALTER whatever .. SET SCHEMA refactoring
Date: 2013-01-15 14:48:47
Message-ID: CADyhKSVOi8oZ-9O1F=FGKiE=RzFKTymSNUGq9nDWEAH-z48Seg@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2013/1/15 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Alvaro Herrera escribió:
>> Kohei KaiGai escribió:
>>
>> > I'm probably saying same idea. It just adds invocation of external
>> > functions to check naming conflicts of functions or collation; that
>> > takes additional 4-lines for special case handling
>> > in AlterObjectNamespace_internal().
>>
>> Okay, I can agree with this implementation plan.
>
> Actually, now that I look again, this is all completely broken, because
> the "object already exists in schema foo" message is using
> getObjectDescription infrastructure, which we agree to be completely
> wrong.
>
http://www.postgresql.org/message-id/CADyhKSWVqaA6iF5wVuW5EzLaiYyCYEE2zO9guqNKy8FRdLx5Gw@mail.gmail.com

Does this patch help the trouble?
It adds ereport_on_namespace_conflict() for error message generation instead of
getObjectDescription() for ALTER RENAME primarily, but I also noticed it can be
applied on getObjectDescription() of AlterObjectNamespace_internal.

Thanks,
-- 
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>


In response to

Responses

pgsql-hackers by date

Next:From: Claudio FreireDate: 2013-01-15 14:55:31
Subject: Re: [PATCH] COPY .. COMPRESSED
Previous:From: Jan WieckDate: 2013-01-15 14:43:04
Subject: Re: strange OOM errors with EXECUTE in PL/pgSQL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group