Skip site navigation (1) Skip section navigation (2)

Re: [v9.2] Fix Leaky View Problem

From: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Kohei(dot)Kaigai(at)emea(dot)nec(dot)com, thom(at)linux(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [v9.2] Fix Leaky View Problem
Date: 2012-01-22 10:57:36
Message-ID: CADyhKSVJPR7LSGQ3otQ5xkrSqmrrbF1=u=X7ViArB1hXRw7Dig@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2012/1/21 Jeff Janes <jeff(dot)janes(at)gmail(dot)com>:
> On Tue, Jan 17, 2012 at 7:08 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sun, Jan 8, 2012 at 10:32 AM, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
>>>>> I guess you concerned about that expected/select_views_1.out is
>>>>> patched, not expected/select_views.out.
>>>>> I'm not sure the reason why regression test script tries to make diff
>>>>> between results/select_views and expected/select_views_1.out.
>>>>
>>>> select_views.out and select_views_1.out are alternate expected output
>>>> files.  The regression tests pass if the actual output matches either
>>>> one.  Thus, you have to patch both.
>>>>
>>> It was new for me. The attached patch updates both of the expected
>>> files, however, I'm not certain whether select_view.out is suitable, or
>>> not, because my results/select_view.out matched with expected/select_view_1.out.
>>
>> Committed.  We'll see what the buildfarm thinks.
>
> This passes installcheck initially.  Then upon second invocation of
> installcheck, it fails.
>
> It creates the role "alice", and doesn't clean it up.  On next
> invocation alice already exists and cases a failure in test
> select_views.
>
Thanks for your pointing out.

The attached patch adds cleaning-up part of object being defined
within this test;
includes user "alice".

Thanks,
-- 
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>

Attachment: pgsql-v9.2-fix-regtest-select-views-cleanup.patch
Description: application/octet-stream (2.9 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Giuseppe SucameliDate: 2012-01-22 13:22:06
Subject: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin"
Previous:From: Kohei KaiGaiDate: 2012-01-22 10:12:17
Subject: Re: [v9.2] LEAKPROOF attribute of FUNCTION (Re: [v9.2] Fix Leaky View Problem)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group