Skip site navigation (1) Skip section navigation (2)

Re: contrib/sepgsql regression tests are a no-go

From: Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: contrib/sepgsql regression tests are a no-go
Date: 2011-09-27 08:13:17
Message-ID: CADyhKSUMhM_YTGCCofTYhPwkuF3og8cPqB+j-EE704QoHwB64Q@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2011/9/26 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> writes:
>> How about this fix on regression test of sepgsql?
>
> IMO, the fundamental problem with the sepgsql regression tests is that
> they think they don't need to play by the rules that apply to every
> other PG regression test.  I don't think this patch is fixing that
> problem; it's just coercing pgxs.mk to assist in not playing by the
> rules, and adding still more undocumented complexity to the PGXS
> mechanisms in order to do so.
>
> If we have to have a nonstandard command for running the sepgsql
> regression tests, as it seems that we do, we might as well just make
> that an entirely local affair within contrib/sepgsql.
>
Are you suggesting to make a command/script to check OS environment
and run its own regression test without touching existing pg_regress
framework, even if it just utilizes existing options?
It seems to me re-inventment of a wheel....

Thanks,
-- 
KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>

In response to

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2011-09-27 08:33:31
Subject: Re: unite recovery.conf and postgresql.conf
Previous:From: Kohei KaiGaiDate: 2011-09-27 08:05:38
Subject: Re: [v9.2] Fix Leaky View Problem

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group