| From: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: Let file_fdw access COPY FROM PROGRAM |
| Date: | 2016-09-10 23:04:27 |
| Message-ID: | CADkLM=dOHp_4B_90-sPeVSmw4v0fSR-NChL+WScN37qT-gDeAg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
V2 of this patch:
Changes:
* rebased to most recent master
* removed non-tap test that assumed the existence of Unix sed program
* added non-tap test that assumes the existence of perl
* switched from filename/program to filename/is_program to more closely
follow patterns in copy.c
* slight wording change in C comments
On Thu, Sep 8, 2016 at 6:59 PM, Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
wrote:
> On 9 Sep. 2016 03:45, "Corey Huinker" <corey(dot)huinker(at)gmail(dot)com> wrote:
> >
> >
>
> > Stylistically, would a separate .pl file for the emitter be preferable
> to something inline like
> >
> >> perl -e 'print "a\tb\tcc\t4\n"; print "b\tc\tdd\t5\n"'
>
> I'd be fine with that and a suitable comment. Just be careful with
> different platforms' shell escaping rules.
>
| Attachment | Content-Type | Size |
|---|---|---|
| file_fdw_program_v2.diff | text/plain | 15.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2016-09-11 02:50:14 | Re: feature request: explain "with details" option |
| Previous Message | Mark Kirkwood | 2016-09-10 22:40:15 | Re: Write Ahead Logging for Hash Indexes |