Re: unaccent extension missing some accents

From: J Smith <dark(dot)panda+lists(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Florian Pflug <fgp(at)phlo(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: unaccent extension missing some accents
Date: 2011-11-07 05:52:42
Message-ID: CADFUPgcFVsSBMjAXdy74bv=PJ9bs9eJtqGQQT3_Pyp9LPPmYvA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alright, I wrote up another patch that uses strchr to parse out the
lines of the unaccent.rules file, foregoing sscanf completely.
Hopefully this looks a bit better than using swscanf.

As for the other problems with isspace and such on OSX, it might be
worth looking at the python portability fixes. I played briefly with
the isspace and friends macros they have and they looked okay, but I
certainly can't speak for how well they'd work for the rest of the
PostgreSQL code base.

Cheers.

Attachment Content-Type Size
0001-Fix-weirdness-when-dealing-with-UTF-8-in-buggy-libc-.patch application/octet-stream 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2011-11-07 10:53:12 Re: Storing hot members of PGPROC out of the band
Previous Message Peter Eisentraut 2011-11-07 05:13:05 -Wcast-qual cleanup, part 1