From:
Phil Sorber <phil(at)omniti(dot)com>
To:
Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc:
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [WIP] pg_ping utility
Date:
2012-12-07 03:56:57
Message-ID:
CADAkt-jNnp=F4qCJYF_tCFWDDh+Wn7yxyBwG0wyUSn496JG8oA@mail.gmail.com (view raw or flat )
Thread:
2012-10-13 21:19:52 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-15 21:28:36 from Thom Brown <thom(at)linux(dot)com>
2012-10-15 21:32:07 from Andres Freund <andres(at)2ndquadrant(dot)com>
2012-10-15 21:40:15 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-15 23:12:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-10-15 23:32:46 from "David Johnston" <polobo(at)yahoo(dot)com>
2012-10-16 01:08:52 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-10-15 23:36:43 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-16 01:18:56 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-10-16 01:47:02 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-21 20:51:21 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-21 22:20:10 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-10-22 15:47:13 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-23 22:12:37 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-10-23 22:22:44 from Christopher Browne <cbbrowne(at)gmail(dot)com>
2012-10-24 00:19:56 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-24 00:10:35 from Phil Sorber <phil(at)omniti(dot)com>
2012-10-24 13:24:43 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-10-24 13:57:32 from Thom Brown <thom(at)linux(dot)com>
2012-10-24 14:02:51 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-11-16 02:23:15 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-16 03:34:37 from Phil Sorber <phil(at)omniti(dot)com>
2012-11-16 03:55:25 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-16 04:38:09 from Phil Sorber <phil(at)omniti(dot)com>
2012-11-16 05:28:40 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2012-11-16 17:43:23 from Phil Sorber <phil(at)omniti(dot)com>
2012-11-19 00:45:34 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-16 17:48:01 from Phil Sorber <phil(at)omniti(dot)com>
2012-11-19 00:44:03 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-23 14:48:58 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-26 02:17:19 from Phil Sorber <phil(at)omniti(dot)com>
2012-11-26 02:18:15 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-26 15:26:27 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-11-26 15:41:10 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-26 18:14:52 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-11-27 04:32:15 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2012-11-27 10:35:31 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2012-11-27 13:45:05 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-11-27 14:43:30 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-01 20:56:11 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-04 04:59:15 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-12-05 05:46:37 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-05 07:28:12 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-12-05 13:53:08 from Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
2012-12-05 15:29:38 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-07 01:54:52 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-12-07 03:56:57 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-08 12:50:18 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-12-08 13:59:00 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-11 15:06:50 from Bruce Momjian <bruce(at)momjian(dot)us>
2012-12-19 13:28:49 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-12-21 19:07:20 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-23 14:29:00 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2012-12-23 14:37:02 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-23 14:57:15 from "Erik Rijkers" <er(at)xs4all(dot)nl>
2012-12-23 15:07:26 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-23 15:44:38 from Phil Sorber <phil(at)omniti(dot)com>
2012-12-25 06:47:40 from Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
2013-01-18 21:17:54 from Phil Sorber <phil(at)omniti(dot)com>
2013-01-20 13:40:52 from Robert Haas <robertmhaas(at)gmail(dot)com>
2013-01-20 14:58:34 from Phil Sorber <phil(at)omniti(dot)com>
2013-01-20 16:38:27 from Robert Haas <robertmhaas(at)gmail(dot)com>
2013-01-20 19:59:04 from Phil Sorber <phil(at)omniti(dot)com>
2013-01-21 03:26:59 from Robert Haas <robertmhaas(at)gmail(dot)com>
2013-01-21 03:36:33 from Craig Ringer <craig(at)2ndQuadrant(dot)com>
Lists:
pgsql-hackers
On Thu, Dec 6, 2012 at 8:54 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
>
>
> On Thu, Dec 6, 2012 at 12:29 AM, Phil Sorber <phil(at)omniti(dot)com> wrote:
>>
>> On Wed, Dec 5, 2012 at 8:53 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
>> wrote:
>> > No, I think it is the reference docs on the returned value that must be
>> > fixed. That is, instead of saying that the return value correspond to
>> > the enum values, you should be saying that it will return
>> > <literal>0</literal> if it's okay, 1 in another case and 2 in yet
>> > another case. And then next to the PQping() enum, add a comment that
>> > the values must not be messed around with because pg_isready exposes
>> > them to users and shell scripts.
>>
>> +1 I'm on board with this.
>
> OK. Let's do that and then mark this patch as ready for committer.
> Thanks,
Those changes have been made.
>
> --
> Michael Paquier
> http://michael.otacoo.com
Something I was just thinking about while testing this again. I
mentioned the issue before about someone meaning to put -v and putting
-V instead and it being a potential source of problems. What about
making verbose the default and removing -v and adding -q to make it
quiet? This would also match other tools behavior. I want to get this
wrapped up and I am fine with it as is, but just wanted to ask what
others thought.
Thanks.
In response to
Responses
pgsql-hackers by date
Next :From: Alvaro HerreraDate: 2012-12-07 04:02:26Subject : Re: pg_upgrade problem with invalid indexesPrevious :From : Pavan DeolaseeDate : 2012-12-07 03:51:50Subject : Re: Setting visibility map in VACUUM's second phase
