Re: Freeze avoidance of very large table.

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Greg S <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Freeze avoidance of very large table.
Date: 2016-03-08 17:59:18
Message-ID: CAD21AoB4qnyTO3_nY05dSiN2PRUen=39MHxSD=Out9ZXz7-UZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 9, 2016 at 1:23 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> On Tue, Mar 8, 2016 at 5:30 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> I left out the relkind check from the final commit because, for one
> thing, the check you added isn't actually right: toast relations can
> also have a visibility map. And also, I'm sort of wondering what the
> point of that check is. What does it protect us from? It doesn't
> seem very future-proof ... what if we add a new relkind in the future?
> Do we really want to have to update this?
>
> How about instead changing things so that we specifically reject
> indexes? And maybe some kind of a check that will reject anything
> that lacks a relfilnode? That seems like it would be more on point.
>

I agree, I don't have strong opinion about this.
It would be good to add condition for rejecting only indexes.
Attached patches are,
- Change heap2 rmgr description
- Add condition to pg_visibility
- Fix typo in pgvisibility.sgml
(Sorry for the late notice..)

Regards,

--
Masahiko Sawada

Attachment Content-Type Size
fix_typo.patch application/x-patch 809 bytes
add_condition_to_pgvisibility.patch application/x-patch 2.0 KB
add_flags_to_heap2_desc.patch application/x-patch 551 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-03-08 18:21:05 Re: Freeze avoidance of very large table.
Previous Message Josh berkus 2016-03-08 17:54:13 Re: JPUG wants to have a copyright notice on the translated doc