Skip site navigation (1) Skip section navigation (2)

Re: patch for parallel pg_dump

From: Joachim Wieland <joe(at)mcknight(dot)de>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch for parallel pg_dump
Date: 2012-03-29 01:12:31
Message-ID: CACw0+134bncrX2=L-fB6qXXR0e7eLCyGugfDbK7a0ApFCCKX7w@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Mar 29, 2012 at 2:46 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> But your patch hasn't got rid of them, and so it's declared twice. There is
> no pgpipe.h, BTW, it's declared in port.h. If VC2005 doesn't complain about
> the double declaration then that's a bug in the compiler, IMNSHO. Doesn't it
> even issue a warning? I no longer use VC2005 for anything, BTW, I use VC2008
> or later.

I agree, the compiler should have found it, but no, I don't even get a
warning. I just verified it and when I add a #error right after the
prototypes in port.h then it hits the #error on every file, so it
definitely sees both prototypes and doesn't complain... cl.exe is
running with /W3.


> Anyway, ISTM the best thing is just for us to get rid of pgpipe without
> further ado. I'll try to get a patch together for that.

Thanks.

In response to

Responses

pgsql-hackers by date

Next:From: Joachim WielandDate: 2012-03-29 01:54:53
Subject: Re: patch for parallel pg_dump
Previous:From: Tom LaneDate: 2012-03-29 01:09:41
Subject: Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group