| From: | Joachim Wieland <joe(at)mcknight(dot)de> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch for parallel pg_dump |
| Date: | 2012-03-29 00:28:54 |
| Message-ID: | CACw0+10jHnkSxJZmpM2AP=_KqsCy2n1h7TzsMk0z8YMmViZw4A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 28, 2012 at 5:19 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> First hurdle: It doesn't build under Windows/mingw-w64:
>
> parallel.c:40:12: error: static declaration of 'pgpipe' follows
> non-static declaration
Strange, I'm not seeing this but I'm building with VC2005. What
happens is that you're pulling in the pgpipe.h header. I have moved
these functions as static functions into pg_dump since you voted for
removing them from the other location (because as it turned out,
nobody else is currently using them).
Joachim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2012-03-29 00:43:23 | Re: ECPG FETCH readahead |
| Previous Message | Peter Geoghegan | 2012-03-28 23:52:23 | Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation) |