Re: Add generate_series(numeric, numeric)

From: Ali Akbar <the(dot)apaan(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Платон Малюгин <malugin(dot)p(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add generate_series(numeric, numeric)
Date: 2015-01-14 02:04:08
Message-ID: CACQjQLpn-+--2s7nTPABeMfs0SGeV_0=Ww+BgDwp1dUzaL5PFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-12-18 19:35 GMT+07:00 Fujii Masao <masao(dot)fujii(at)gmail(dot)com>:

> On Mon, Dec 15, 2014 at 2:38 PM, Andrew Gierth
> <andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
> > I was thinking something like this, added just after that para:
> >
> > <warning>
> > <para>
> > While the actual arguments to the function remain unchanged between
> > calls, if you detoast the argument values (which is normally done
> > transparently by the
> > <function>PG_GETARG_<replaceable>xxx</replaceable></function>
> macro)
> > in the transient context then the detoasted copies will be freed on
> > each cycle. Accordingly, if you keep references to such values in
> > your <structfield>user_fctx</>, you must either copy them into the
> > <structfield>multi_call_memory_ctx</> after detoasting, or ensure
> > that you detoast the values only in that context.
> > </para>
> > </warning>
>
> I'm OK with this.
>

Wrapping the doc changes in a patch. Will add to next commitfest so it
won't be lost.

--
Ali Akbar

Attachment Content-Type Size
srf_add_doc.patch text/x-diff 1009 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-01-14 03:19:30 Minor configure tweak to simplify adjusting gcc warnings
Previous Message Andres Freund 2015-01-14 01:25:43 Re: EXEC_BACKEND + logging_collector=on is broken